Skip to content

[Fix] Remove MoRI-IO patches from vLLM Disagg benchmarks #1585

Draft
simondanielsson wants to merge 1 commit into
mainfrom
fix/remove-vllm-disagg-patches
Draft

[Fix] Remove MoRI-IO patches from vLLM Disagg benchmarks #1585
simondanielsson wants to merge 1 commit into
mainfrom
fix/remove-vllm-disagg-patches

Conversation

@simondanielsson
Copy link
Copy Markdown
Collaborator

These patches were upstreamed in vllm-project/vllm#40344 so we can use the nightly image instead.

Run: https://github.com/SemiAnalysisAI/InferenceX/actions/runs/26624643555

…m image

Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant